Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 12 support #314

Closed
wants to merge 2 commits into from
Closed

Conversation

domdomegg
Copy link
Contributor

Description

CI is broken on Node 12, which is a end of life version of Node. graphql-code-generator already dropped support for Node 12.

Related #312

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

🦋 Changeset detected

Latest commit: 9ed834c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages
Name Type
@graphql-codegen/c-sharp Major
@graphql-codegen/c-sharp-common Major
@graphql-codegen/c-sharp-operations Major
@graphql-codegen/flutter-freezed Major
@graphql-codegen/flow Major
@graphql-codegen/flow-operations Major
@graphql-codegen/flow-resolvers Major
@graphql-codegen/java-apollo-android Major
@graphql-codegen/java-common Major
@graphql-codegen/java Major
@graphql-codegen/kotlin Major
@graphql-codegen/java-resolvers Major
@graphql-codegen/hasura-allow-list Major
@graphql-codegen/jsdoc Major
@graphql-codegen/urql-introspection Major
@graphql-codegen/typescript-apollo-angular Major
@graphql-codegen/typescript-apollo-client-helpers Major
@graphql-codegen/typescript-enum-array Major
@graphql-codegen/typescript-generic-sdk Major
@graphql-codegen/typescript-graphql-apollo Major
@graphql-codegen/typescript-graphql-files-modules Major
@graphql-codegen/typescript-graphql-request Major
@graphql-codegen/typescript-jit-sdk Major
@graphql-codegen/typescript-mongodb Major
@graphql-codegen/typescript-msw Major
@graphql-codegen/named-operations-object Major
@graphql-codegen/typescript-nhost Major
@graphql-codegen/typescript-oclif Major
@graphql-codegen/typescript-react-apollo Major
@graphql-codegen/typescript-react-offix Major
@graphql-codegen/typescript-react-query Major
@graphql-codegen/typescript-rtk-query Major
@graphql-codegen/typescript-stencil-apollo Major
@graphql-codegen/typescript-type-graphql Major
@graphql-codegen/typescript-urql Major
@graphql-codegen/typescript-urql-graphcache Major
@graphql-codegen/urql-svelte-operations-store Major
@graphql-codegen/typescript-vue-apollo Major
@graphql-codegen/typescript-vue-apollo-smart-ops Major
@graphql-codegen/typescript-vue-urql Major
@graphql-codegen/import-types-preset Major
@graphql-codegen/near-operation-file-preset Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@domdomegg
Copy link
Contributor Author

image

image

@domdomegg
Copy link
Contributor Author

@n1ru4l I think this is ready for your review.

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also want to upgrade codegen version before we merge this so it is a single major bump. So let's sequence all those in one release.

@saihaj
Copy link
Collaborator

saihaj commented Sep 25, 2023

@domdomegg looks like we have some conflicts, can you help resolve those?

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Sep 25, 2023
@HermanBilous
Copy link
Contributor

@saihaj, This change should be obsolete since #348 already dropped support for v12 and v14.

@saihaj saihaj removed the waiting-for-answer Waiting for answer from author label Sep 25, 2023
@saihaj
Copy link
Collaborator

saihaj commented Sep 25, 2023

thank you

@saihaj saihaj closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants