Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph-cache-config): correct IntrospectionData #297

Merged
merged 7 commits into from
Mar 27, 2023
Merged

fix(graph-cache-config): correct IntrospectionData #297

merged 7 commits into from
Mar 27, 2023

Conversation

dargmuesli
Copy link
Contributor

Description

In @urql/exchange-graphcache@v5.2.0 IntrospectionData is no longer exported, but can be accessed via CacheExchangeOpts's schema property.

urql-graphql/urql#3027 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

n/a

How Has This Been Tested?

Updated existing test & snapshot.

Test Environment:

CI

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

In `@urql/exchange-graphcache@v5.2.0` `IntrospectionData` is no longer exported, but can be accessed via `CacheExchangeOpts`'s schema property.
@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2023

🦋 Changeset detected

Latest commit: c49e9d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-urql-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dargmuesli
Copy link
Contributor Author

@ardatan @B2o5T I see that you contributed to this repository a bit and had recent activity. Given the reactions to this MR, could you review this MR or is this out of scope for you? 🙏 Thank you for your contributions!

@dargmuesli
Copy link
Contributor Author

I fixed the formatting :)

@saihaj
Copy link
Collaborator

saihaj commented Mar 23, 2023

@dargmuesli looks like some tests are still broken

@dargmuesli
Copy link
Contributor Author

You're right, sorry. It's hard to see which of the many scripts one needs to run. I now went through all ci scripts and hope I got everything. Maybe there could be a "ci" script in the package.json which runs all necessary other scripts that need to run fine so one does not have to wait for each approval or go through the ci definition yml 😄

@saihaj
Copy link
Collaborator

saihaj commented Mar 25, 2023

You're right, sorry. It's hard to see which of the many scripts one needs to run. I now went through all ci scripts and hope I got everything. Maybe there could be a "ci" script in the package.json which runs all necessary other scripts that need to run fine so one does not have to wait for each approval or go through the ci definition yml 😄

feel free to send that PR and we can also update the docs for it!

@dargmuesli
Copy link
Contributor Author

Updated to incorporate #314

@saihaj
Copy link
Collaborator

saihaj commented Mar 27, 2023

@dargmuesli i want to keep EOL node 12 independent so let’s revert that here.

@dargmuesli
Copy link
Contributor Author

Will do once the current GitHub incident is resolved 👍 Do you plan to merge this PR without all tests being green then?

@dargmuesli
Copy link
Contributor Author

Done ✔️

@saihaj saihaj merged commit f73ab71 into dotansimha:main Mar 27, 2023
@saihaj
Copy link
Collaborator

saihaj commented Mar 27, 2023

released @dargmuesli @graphql-codegen/typescript-urql-graphcache@2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants