Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dependabot to project #829

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

mateusoliveira43
Copy link
Collaborator

Signed-off-by: Mateus Oliveira msouzaol@redhat.com

Describe the behavior changes introduced in this PR

Let dependabot update github actions for us.

Linked Issues

resolves #827

Testing Instructions

After we close the PR, we need to enable it, and then it will start working.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mpryc
Copy link
Collaborator

mpryc commented Jan 31, 2023

@mateusoliveira43 could you please describe what that bot will be doing? E.g. proposing new PRs with updated github action versions or merge new versions to the codebase? Will this PR need review etc?

I am also wondering here if prow requires adding that bot as reviewer to adjust branch protection rules.

@mateusoliveira43
Copy link
Collaborator Author

@mateusoliveira43 could you please describe what that bot will be doing? E.g. proposing new PRs with updated github action versions or merge new versions to the codebase? Will this PR need review etc?

I am also wondering here if prow requires adding that bot as reviewer to adjust branch protection rules.

It will opens PR, like in this example and them we merge if we want, or after we change something.

I did not have to do anything more than creating the dependabot.yml file and enabling it on settings for my personal project. I think we can see how it does without adding it, and if we need, we add it later.

@mateusoliveira43
Copy link
Collaborator Author

/retest

1 similar comment
@mateusoliveira43
Copy link
Collaborator Author

/retest

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43
Copy link
Collaborator Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

@mateusoliveira43: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.8-e2e-openshift cc47dc8 link false /test 4.8-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mpryc
Copy link
Collaborator

mpryc commented Feb 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@mpryc mpryc merged commit 0acf429 into dora-metrics:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependabot to project
2 participants