Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At least one reviewer should happen before push btn is enabled #409

Closed
mpryc opened this issue Apr 6, 2022 · 6 comments
Closed

At least one reviewer should happen before push btn is enabled #409

mpryc opened this issue Apr 6, 2022 · 6 comments
Assignees
@mpryc @mateusoliveira43
Labels
needs investigation More research is necessary for this task, usually from developers of the project.

Comments

@mpryc
Copy link
Collaborator

mpryc commented Apr 6, 2022

With introduction of OpenShift CI robot there is no longer requirement of one person to review the code before enabling the Merge btn in the github UI. That should be changed.
@KevinMGranger
Copy link
Collaborator

@weshayutin any ideas on why this is happening?

@weshayutin
Copy link
Contributor

@mpryc @KevinMGranger agreed.. I'll see what I can find out.

@KevinMGranger
Copy link
Collaborator

KevinMGranger commented Apr 11, 2022 •
edited
Loading

Fixed by openshift/release#27739 !

@KevinMGranger
Copy link
Collaborator

Might not be fixed yet, still testing. See comment in #414

@KevinMGranger KevinMGranger reopened this Apr 11, 2022
@KevinMGranger
Copy link
Collaborator

Let's test this today @mpryc @mateusoliveira43

@KevinMGranger KevinMGranger added the needs investigation More research is necessary for this task, usually from developers of the project. label Jan 30, 2023
@mateusoliveira43
Copy link
Collaborator

tested here #829

I believe it is safe
Screenshot from 2023-01-31 16-20-52

I can not merge without 1 approve (and I cannot approve myself)
Screenshot from 2023-01-31 13-55-36

@mpryc mpryc closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpryc mpryc

@mateusoliveira43 mateusoliveira43

Labels
needs investigation More research is necessary for this task, usually from developers of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weshayutin @KevinMGranger @mpryc @mateusoliveira43