Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pelorus Operator v0.0.1 - Community Operator candidate #752

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Dec 16, 2022

Pelorus Operator which is the candidate for the Community Operator

To install:

operator-sdk run bundle quay.io/pelorus/pelorus-operator-bundle:v0.0.1 --namespace pelorus

Signed-off-by: Michal Pryc mpryc@redhat.com

@redhat-cop/mdt

@mateusoliveira43
Copy link
Collaborator

More a question then a request: should the operator stuff live in a separated repo?

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 16, 2022

More a question then a request: should the operator stuff live in a separated repo?

We did talk about this previously and we may end up moving it to separate repo in the future. Currently it's easier to have it in same repo, because it uses helm-charts from pelorus one.

@mateusoliveira43
Copy link
Collaborator

Now that we will version it, I believe is important to check if the version is correct (I have already bumped a personal project from 0.0.1 to 0.1.1, for example) . I believe there is a better solution for this, but I use this in one project https://github.com/mateusoliveira43/cly/blob/main/tests/test_version.py#L84

And we should configure an action to automatically updated the operator in the marketplace as well, when version change occurs

I would wait to have these two features before merging this PR

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 16, 2022

/retest

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 16, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022
@mpryc
Copy link
Collaborator Author

mpryc commented Dec 16, 2022

This isn't yet passing the redhat-openshift-ecosystem/community-operators-prod#1967

Some labels are missing

@mpryc mpryc force-pushed the operator_pelorus_quay_org branch from 497bec5 to 632446a Compare December 19, 2022 11:28
Pelorus Operator which is the candidate for the Community Operator

To install:

operator-sdk run bundle quay.io/pelorus/pelorus-operator-bundle:v0.0.1 --namespace pelorus

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@mpryc mpryc force-pushed the operator_pelorus_quay_org branch from 632446a to f7b8f64 Compare December 19, 2022 11:58
@mpryc
Copy link
Collaborator Author

mpryc commented Dec 19, 2022

The upstream community operator PR (which is copy-paste from the generated bundle folder): redhat-openshift-ecosystem/community-operators-prod#1967

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 19, 2022

/retest

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 19, 2022

/test 4.10-e2e-openshift

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 19, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2022
@KevinMGranger
Copy link
Collaborator

Looks like this is released?

@mpryc
Copy link
Collaborator Author

mpryc commented Dec 20, 2022

Looks like this is released?

Yes, my hope was that this PR got merged prior to redhat-openshift-ecosystem/community-operators-prod#1967 but looks like the community operators got first in. If we can get this PR merged that would ensure we are 1-1 with what's in the community-operators-prod. I will propose some process to ensure we always get those two together. The community-operators-prod is at higher priority as there is number of CI jobs already implemented to ensure installation is correct for number of OCP releases.

@KevinMGranger KevinMGranger merged commit 45516ab into dora-metrics:master Dec 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinMGranger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants