Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pelorus Operator as first-class citizen for our docs #767

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Jan 9, 2023

Update docs to ensure pelorus operator is covered.

Signed-off-by: Michal Pryc mpryc@redhat.com

Testing Instructions

https://pelorus--767.org.readthedocs.build/en/767/

@redhat-cop/mdt

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes labels Jan 9, 2023
@mpryc
Copy link
Collaborator Author

mpryc commented Jan 9, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2023
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
@mateusoliveira43
Copy link
Collaborator

mateusoliveira43 commented Jan 9, 2023

I would also apply some changes I made here #759

  • Move install to the top to be the first section of getting started
  • Remove Pelorus installation steps from demo (quickstart tutorial) and add a reference to it

[EDITED] we merged #759, so all this changes were applied

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@mpryc mpryc force-pushed the operator_docs branch 5 times, most recently from cecaf4a to 90cb253 Compare January 10, 2023 17:59
@mpryc mpryc changed the title WIP: Use Pelorus Operator as first-class citizen for our docs Use Pelorus Operator as first-class citizen for our docs Jan 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@mpryc
Copy link
Collaborator Author

mpryc commented Jan 10, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@mpryc
Copy link
Collaborator Author

mpryc commented Jan 10, 2023

/retest

docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Show resolved Hide resolved
docs/Install.md Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/configuration2.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
docs/Install.md Outdated Show resolved Hide resolved
Update docs to ensure pelorus operator is covered.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mateusoliveira43
Once this PR has been reviewed and has the lgtm label, please ask for approval from mpryc by writing /assign @mpryc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc
Copy link
Collaborator Author

mpryc commented Jan 10, 2023

Approved by @mateusoliveira43 merging without waiting for the e2e tests as it's just doc update, so no real need for those to end.

@mpryc mpryc merged commit cf2d52c into dora-metrics:master Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

@mpryc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.8-e2e-openshift 90cb253 link false /test 4.8-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants