-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report filter module #140 #143
Report filter module #140 #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
Didn't try it out yet, but I found a small typo.
core/reporter.go
Outdated
// FilterBillable returns a records if its IsBillable flag matches the paramter display | ||
func FilterBillable(dislay bool) func(*Record) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rewording the comment. And a small typo in the param.
// FilterBillable returns a records if its IsBillable flag matches the paramter display | |
func FilterBillable(dislay bool) func(*Record) bool { | |
// FilterBillable returns a record filter for the billable flag that filters based on the passed display value | |
func FilterBillable(display bool) func(*Record) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes that's a little weird, I will fix that..thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for implementing this! 👍
closing #140
sample output: