Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include project modules in reports when using the --project option #140

Closed
dominikbraun opened this issue Jun 27, 2021 · 5 comments
Closed
Labels

Comments

@dominikbraun
Copy link
Owner

Currently, project modules don't seem to be included when generating a report using timetrace report and specifying a --project filter. The logic for including modules of a project already exists for timetrace list projects - maybe this can be re-used.

@KonstantinGasser
Copy link
Contributor

So currently report lists projects and their submodules as different rows in the report. I guess the idea is to have the project as parent row with all its submodules? And the filter would look like -p grind@make-coffee filtering for only records belonging to the make-coffee project and grind module, right?

Also this means, that the table needs to be appended with a module column, right?

KonstantinGasser pushed a commit to KonstantinGasser/timetrace that referenced this issue Jun 27, 2021
@KonstantinGasser
Copy link
Contributor

I opened a PR for this issue.

@dominikbraun
Copy link
Owner Author

So currently report lists projects and their submodules as different rows in the report. I guess the idea is to have the project as parent row with all its submodules? And the filter would look like -p grind@make-coffee filtering for only records belonging to the make-coffee project and grind module, right?

Also this means, that the table needs to be appended with a module column, right?

I have yet to think about this tbh, but this doesn't sound bad.

@KonstantinGasser
Copy link
Contributor

In the PR I have provided some sample outputs to get a touch and feel. I think it somehow makes to provide this in the report sense since timetrace does support modules..

@dominikbraun dominikbraun added this to the timetrace v0.12.0 milestone Jun 28, 2021
@dominikbraun
Copy link
Owner Author

Closed by #143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants