Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

[gh-21] Potential fix for map-stream integration with multipipe. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashmind
Copy link

@ashmind ashmind commented Jan 1, 2017

This is a potential fix for #21.

All existing test pass, but unfortunately I don't know streams well to do a proper new test.

I've inlined wrappedMapper — to reduce confusion between the callback it took (which was always next) and a new callback that write takes.

@dominictarr
Copy link
Owner

I think there should be a simpler solution that doesn't require changes to map-stream, I suspect that emitting a finish event should be enough

@ashmind
Copy link
Author

ashmind commented Feb 11, 2017

@dominictarr I'm not really a stream expert — the callback approach fixed the problem and made sense for me — but if you know a better fix all the better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants