Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

map-stream never ends when used inside of multipipe #21

Open
ashmind opened this issue Dec 31, 2016 · 1 comment
Open

map-stream never ends when used inside of multipipe #21

ashmind opened this issue Dec 31, 2016 · 1 comment

Comments

@ashmind
Copy link

ashmind commented Dec 31, 2016

I'm using a Gulp plugin called gulp-svg2png which uses map-stream internally.

When I use it with the multipipe, the stream end never happens (though gulp does exit). I have narrowed it down to map-stream not using the third callback argument of stream.write: https://github.com/dominictarr/map-stream/blob/master/index.js#L89. I'm not a Node stream expert, but it seems that if I accept the callback and call it when required, then everything works as expected.

@ashmind
Copy link
Author

ashmind commented Jan 1, 2017

Removed potential solution from the description above -- I have a better solution in a fork so I'll PR it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant