This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Simple object filters #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #83 diff @@
====================================
Files 16 16
Lines 1129 1142 +13
Methods 6 6
Messages 0 0
Branches 196 201 +5
====================================
+ Hits 1129 1142 +13
Misses 0 0
Partials 0 0
|
rorticus
approved these changes
Jan 11, 2017
maier49
force-pushed
the
simple-object-filters
branch
from
a4dc0ce to
5c2ad9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
This allows filters to be created from simple object literals. Any filters created by the
createFiltermodule will also contain these properties so they could be converted to and from JSON and be used to reconstruct the same filters. This doesn't resolve #81 completely but it is related.Related Issue: #81
Please review this checklist before submitting your PR: