Change path rewriting to use req.accepts in serve mode #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 10 10
Lines 621 621
Branches 156 156
=======================================
Hits 324 324
Misses 297 297
Continue to review full report at Codecov.
|
agubler
approved these changes
Mar 7, 2019
agubler
pushed a commit
to agubler/cli-build-app
that referenced
this pull request
Mar 8, 2019
* change to using req.accepts * package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettierDescription:
The previous fix didn't actually work