V5 - Add slash to paths that need them in serve #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add slash to paths that need them * only rewrite on html type requests * fix test
agubler
changed the title
* change to using req.accepts * package-lock
|
@matt-gadd I've updated this back port with the latest pull request |
Codecov Report
@@ Coverage Diff @@
## v5 #252 +/- ##
==========================================
- Coverage 52.43% 52.17% -0.27%
==========================================
Files 10 10
Lines 616 621 +5
Branches 155 156 +1
==========================================
+ Hits 323 324 +1
- Misses 293 297 +4
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
Description:
In serve mode, if serve-static can't resolve a file it sends a 301 redirect with an additional slash. This causes problems with relative paths on the page afterwards.
Rather than having this behaviour, instead opt to add the slash before resolving in serve-static.
Backport of #247 & #253