[BACKPORT] Adding new flags to pkidestroy #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: Bug 1372056 Ticket: https://pagure.io/dogtagpki/issue/1172 List of changes with this commit: - Adds new flag `--force` to pkidestroy to force remove a subsystem - Use `os.path.join()` instead of appending '/' between path names - Remove the `pki_database_path` dir instead of removing contents of the dir - This is moved to `security_database.py` instead of `configuration.py` - pkidestroy and pkispawn logs are owned by `root` instead of configured pkiuser Signed-off-by: Dinesh Prasanth M K<dmoluguw@redhat.com>
Partially resolves: Bug 1372056 List of changes by this commit: - Logs are preserved by default (comment #1 in BZ) - Add `--remove-flags` flag to pkidestroy to remove logs Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
This commit removes obsolete code Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
Resolves: Bug 1644769 Ticket: https://pagure.io/dogtagpki/issue/3077 - `pkidestroy` behaviour was chagned to preserve the logs by default. When `pkispawn` is run, it throws a name space collision error. - This patch reuses the log dir and appends logs to the same log dir structure (if exists) and logs it accordingly. `Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>`
SilleBille
changed the title
SilleBille
added
Enhancement
SilleBille
referenced
this pull request
in SilleBille/pki
Nov 1, 2018
- Skip loading file if cs_conf doesn't exist - Reformat log error in initialization Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
SilleBille
force-pushed
the
pki_destroy_79_85_92
branch
from
3b3ffdd to
fd8bdc6
Compare
SilleBille
referenced
this pull request
in SilleBille/pki
Nov 1, 2018
- Skip loading file if cs_conf doesn't exist - Reformat log error in initialization Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
- Skip loading file if cs_conf doesn't exist - Reformat log error in initialization Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
SilleBille
force-pushed
the
pki_destroy_79_85_92
branch
from
fd8bdc6 to
6a22c8e
Compare
|
There was a minor bug which I added to it. Thanks for the review! Merging... |
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically a squash of changes in master:
#79 - Add
--forceand--remove-logsflag to pki-destroy#85 - Remove obsolete code
#92 - Reuse same instance log dirs (if exists)
The changes in this PR were hand-picked and not cherry-picked. A significant new change introduced by this PR:
pki_database_pathdir instead of removing contents of the dirsecurity_database.pyinstead ofconfiguration.pyThis PR resolves:
Bugs:
1372056,1644769and indirectly1458010Tickets: 1172, 3077
PS: This PR will be rebased to 10_5 branch to maintain commit history.