Remove check against PKI_SIGNED_AUDIT_SUBSYSTEMS #85
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The constant check against PKI_SIGNED_AUDIT_SUBSYSTEMS is no longer useful since it will always be evaluated as TRUE Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
edewata
approved these changes
Oct 29, 2018
| @@ -40,7 +40,6 @@ | |||
| PKI_DEPLOYMENT_DEFAULT_USER = "pkiuser" | |||
|
|
|||
| PKI_SUBSYSTEMS = ["CA", "KRA", "OCSP", "RA", "TKS", "TPS"] | |||
| PKI_SIGNED_AUDIT_SUBSYSTEMS = ["CA", "KRA", "OCSP", "TKS", "TPS"] | |||
| PKI_TOMCAT_SUBSYSTEMS = ["CA", "KRA", "OCSP", "TKS", "TPS"] | |||
There was a problem hiding this comment.
PKI_TOMCAT_SUBSYSTEMS is no longer necessary either since everything is running on Tomcat. In the past TPS ran on Apache HTTPD.
| @@ -40,7 +40,6 @@ | |||
| PKI_DEPLOYMENT_DEFAULT_USER = "pkiuser" | |||
|
|
|||
| PKI_SUBSYSTEMS = ["CA", "KRA", "OCSP", "RA", "TKS", "TPS"] | |||
There was a problem hiding this comment.
The RA can be removed from PKI_SUBSYSTEMS since it was already dropped several years ago.
Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
SilleBille
referenced
this pull request
in SilleBille/pki
Oct 29, 2018
- Introduces `--force` flag to `pkidestroy` to force remove subsystem - Introduces `--remove-logs` flag to `pkidestroy` to remove logs - Logs are stored by default when running pkidestroy - Obsolete constants `PKI_SIGNED_AUDIT_SUBSYSTEMS`, `PKI_TOMCAT_SUBSYSTEMS` and `RA` is removed from `PKI_SUBSYSTEMS` `Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful since it will always be evaluated as TRUE
Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>