Extend dbal config and extension for result cache

[chr-hertel]

This is super embarrassing, what do I overlook, this can't be the solution for #114, right?

tested it successfully with symfony demo:

# config/packages/cache.yaml
framework:
    cache:
        pools:
            cache.dbal:
                adapter: cache.adapter.filesystem

# config/packages/doctrine.yaml
doctrine:
    dbal:
        url: '%env(resolve:DATABASE_URL)%'
        result_cache: 'cache.dbal'

$conn->executeQuery(
    sql: 'SELECT * FROM symfony_demo_post WHERE id = :id',
    params: ['id' => 1],
    qcp: new QueryCacheProfile(
        lifetime: 3600,
        cacheKey: 'my_cache_key',
    ),
);

[dmaicher]

I guess this would be enough indeed 🤔

[ostrolucky]

Why not making it consistent with ORM? There, it's like this

DoctrineBundle/Resources/doc/configuration.rst

Lines 702 to 704 in 0ad7b24

	result_cache_driver:
	type: pool
	pool: doctrine.result_cache_pool

[chr-hertel]

Yes, good point, @ostrolucky, consistency would be great.
Trying to understand the implementation here: https://github.com/doctrine/DoctrineBundle/blob/2.10.x/DependencyInjection/DoctrineExtension.php#L1008-L1024

meaning the difference would be that there is a default ArrayCache registered if type pool is used without identifier?

I guess that feature made more sense before #1352 - or do I miss sth?

Edit: not saying it doesn't make sense to bring in that behavior as well, just only if I miss sth to understand before I do the change

[ostrolucky]

My comment was mostly aimed at the options, not internal workings. In this PR you accept only service ID, while in ORM version you can choose if you use service id or a pool. But perhaps you are right, since DBAL supports symfony pool only, perhaps we should bite the bullet and just accept that ORM and DBAL node will be different and accept just service id. Any opinions from other maintainers on this?

[dmaicher]

I think its fine to just allow a service id.

Actually every cache pool is registered as a service with the pool name as service id anyway, right? So this will allow using cache pools or any custom service (as long as its a PSR cache).

The ORM config technically also still supports the deprecated doctrine/cache instances via CacheCompatibilityPass. But we should not support those for the DBAL result cache.

[ostrolucky]

Fair enough. Let's keep it as this then. Test wouldn't be bad either, but can't really go wrong with such simple change either.

[dmaicher]

This should go into 2.11.x though. Could you rebase it @chr-hertel ?

[ostrolucky]

Target changed. No need to rebase :)

[chr-hertel]

Too late :D

[dmaicher]

let's add a very simple test case so at least the feature is also "documented" via tests

[dmaicher]

Thanks @chr-hertel