Fix compatibility layer for cache services

[alcaeus]

Due to container isolation, we cannot access the definition of the given cache service, which breaks autodetection. Thus, we introduce a new is_psr configuration option to be used with cache services for people to indicate that they are using a PSR-6 cache service.

Includes the test from #1350 in addition to another functional test for a PSR-6 service.

[ostrolucky]

Also UPGRADE-2.4.md should be updated

[alcaeus]

I'll make another attempt at auto-detecting this using a compiler pass...tomorrow 😉

[ostrolucky]

I've pushed a commit which fixes this via compiler pass instead. Would be great if you guys would review & test this, so that we can merge this and release 2.4 soon.

[dmaicher]

@ostrolucky I just tested it and it works nicely except for one case

I tried this config using a doctrine/cache service for metadata caching

    orm:
        default_entity_manager: default
        entity_managers:
            default:
                metadata_cache_driver:
                    type: service
                    id: my.doctrine.cache

this works fine for debug cases but fails for no-debug (when the PhpArrayAdapter is used):

    $ app/console cache:clear --no-debug -vvv
        
        // Clearing the cache for the dev environment with debug false
        
        // Clearing outdated warmup directory...
        
        // Warming up cache...
    
    
    In PhpArrayAdapter.php line 48:
      
      [TypeError]
          Argument 2 passed to Symfony\Component\Cache\Adapter\PhpArrayAdapter::__construct() must implement interface Symfony\Component\Cache\Adapter\AdapterInterface, instance of Symfony\Component\Cache\DoctrinePro
          vider given, called in /var/www/test/symfony/app/cache/de_/ContainerBPTxcrq/appAppKernelDevContainer.php on line 1716
    
    
    Exception trace:
        at /var/www/test/symfony/vendor/symfony/cache/Adapter/PhpArrayAdapter.php:48
        Symfony\Component\Cache\Adapter\PhpArrayAdapter->__construct() at /var/www/test/symfony/app/cache/de_/ContainerBPTxcrq/appAppKernelDevContainer.php:1716
        ContainerBPTxcrq\appAppKernelDevContainer->getDoctrine_Orm_DefaultEntityManagerService() at /var/www/test/symfony/app/cache/de_/ContainerBPTxcrq/appAppKernelDevContainer.php:1654
        ContainerBPTxcrq\appAppKernelDevContainer->ContainerBPTxcrq\{closure}() at /var/www/test/symfony/app/cache/de_/ContainerBPTxcrq/EntityManager_9a5be93.php:22
        Closure->__invoke() at /var/www/test/symfony/app/cache/de_/ContainerBPTxcrq/EntityManager_9a5be93.php:22
        ContainerBPTxcrq\EntityManager_9a5be93->getMetadataFactory() at /var/www/test/symfony/vendor/doctrine/doctrine-bundle/CacheWarmer/DoctrineMetadataCacheWarmer.php:47
        Doctrine\Bundle\DoctrineBundle\CacheWarmer\DoctrineMetadataCacheWarmer->doWarmUp() at /var/www/test/symfony/vendor/symfony/framework-bundle/CacheWarmer/AbstractPhpFileCacheWarmer.php:49
        Symfony\Bundle\FrameworkBundle\CacheWarmer\AbstractPhpFileCacheWarmer->warmUp() at /var/www/test/symfony/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:97
        Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() at /var/www/test/symfony/vendor/symfony/http-kernel/Kernel.php:633
        Symfony\Component\HttpKernel\Kernel->initializeContainer() at /var/www/test/symfony/vendor/symfony/http-kernel/Kernel.php:136
        Symfony\Component\HttpKernel\Kernel->boot() at /var/www/test/symfony/vendor/symfony/http-kernel/Kernel.php:153
        Symfony\Component\HttpKernel\Kernel->reboot() at /var/www/test/symfony/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:189
        Symfony\Bundle\FrameworkBundle\Command\CacheClearCommand->warmup() at /var/www/test/symfony/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:129
        Symfony\Bundle\FrameworkBundle\Command\CacheClearCommand->execute() at /var/www/test/symfony/vendor/symfony/console/Command/Command.php:255
        Symfony\Component\Console\Command\Command->run() at /var/www/test/symfony/vendor/symfony/console/Application.php:1027
        Symfony\Component\Console\Application->doRunCommand() at /var/www/test/symfony/vendor/symfony/framework-bundle/Console/Application.php:97
        Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /var/www/test/symfony/vendor/symfony/console/Application.php:273
        Symfony\Component\Console\Application->doRun() at /var/www/test/symfony/vendor/symfony/framework-bundle/Console/Application.php:83
        Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /var/www/test/symfony/vendor/symfony/console/Application.php:149
        Symfony\Component\Console\Application->run() at /var/www/test/symfony/app/console:35

[alexander-schranz]

Same error for me as @dmaicher when running bin/console cache:clear --env prod on sulu/sulu. Tested with Symfony 5.2.9 and 5.3.0-dev both output the following:

Output:

PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Symfony\Component\Cache\Adapter\PhpArrayAdapter::__construct() must implement interface Symfony\Component\Cache\Adapter\AdapterInterface, instance of Symfony\Component\Cache\DoctrineProvider given, called in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php on line 886 and defined in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/vendor/symfony/cache/Adapter/PhpArrayAdapter.php:48
Stack trace:
#0 /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php(886): Symfony\Component\Cache\Adapter\PhpArrayAdapter->__construct('/Users/me...', Object(Symfony\Component\Cache\DoctrineProvider))
#1 /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php(829): ContainerKCQGinW\A in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/vendor/symfony/cache/Adapter/PhpArrayAdapter.php on line 48

Fatal error: Uncaught TypeError: Argument 2 passed to Symfony\Component\Cache\Adapter\PhpArrayAdapter::__construct() must implement interface Symfony\Component\Cache\Adapter\AdapterInterface, instance of Symfony\Component\Cache\DoctrineProvider given, called in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php on line 886 and defined in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/vendor/symfony/cache/Adapter/PhpArrayAdapter.php:48
Stack trace:
#0 /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php(886): Symfony\Component\Cache\Adapter\PhpArrayAdapter->__construct('/Users/me...', Object(Symfony\Component\Cache\DoctrineProvider))
#1 /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/var/cache/admin/prod/ContainerKCQGinW/App_KernelProdContainer.php(829): ContainerKCQGinW\A in /Users/me/Documents/Sulu/sulu-develop.localhost/vendor/sulu/sulu/vendor/symfony/cache/Adapter/PhpArrayAdapter.php on line 48

[ostrolucky]

Thx for feedback. This should be now fixed

[alexander-schranz]

@ostrolucky can confirm it is fixed for me now!

[Gemorroj]

framework:
    cache:
        pools:
            doctrine.result_cache_pool:
                adapter: cache.adapter.filesystem

doctrine:
    orm:
        result_cache_driver:
            type: pool
            pool: doctrine.result_cache_pool

Argument 1 passed to Doctrine\DBAL\Configuration::setResultCacheImpl() must implement interface Doctrine\Common\Cache\Cache, instance of Symfony\Component\Cache\Adapter\FilesystemAdapter given

[ostrolucky]

@Gemorroj thanks for quick report (although report via issue would be better). Can you try #1360?