Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure connection is closed before deleting sqlite file #1686

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Ensure connection is closed before deleting sqlite file #1686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Command/DropDatabaseDoctrineCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
if ($shouldDropDatabase) {
if ($schemaManager instanceof SqliteSchemaManager) {
// dropDatabase() is deprecated for Sqlite
$connection->close();

Check warning on line 107 in Command/DropDatabaseDoctrineCommand.php

View check run for this annotation

Codecov / codecov/patch

Command/DropDatabaseDoctrineCommand.php#L107 

Added line #L107 was not covered by tests
if (file_exists($name)) {
unlink($name);
}
Expand Down