Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure connection is closed before deleting sqlite file #1686

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Ensure connection is closed before deleting sqlite file #1686

merged 1 commit into from
Jul 24, 2023

Conversation

ostrolucky
Copy link
Member

This should fix inability to drop sqlite DB on Windows OS

Fixes #1658

@ostrolucky
Ensure connection is closed before deleting sqlite file
14bdd32 
This should fix inability to drop sqlite DB on Windows OS
@ostrolucky ostrolucky added the Bug label Jul 21, 2023
@ostrolucky ostrolucky added this to the 2.10.2 milestone Jul 21, 2023
@ostrolucky ostrolucky mentioned this pull request Jul 21, 2023
Closed
dmaicher
dmaicher approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope it fixes the issue 😊 theoretically it should

@ostrolucky ostrolucky merged commit 2004001 into 2.10.x Jul 24, 2023
12 checks passed
@greg0ire greg0ire deleted the fix-issue-1658 branch July 24, 2023 07:57
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Merged
@olberger
Copy link

olberger commented Aug 8, 2023

I confirm a fix in 2.10.2. Many thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.

Cannot drop Sqlite database on windows using doctrine:database:drop
3 participants
@ostrolucky @olberger @dmaicher