This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Add top-level make vendor and run it.
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2017 01:03
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
|
Before this is merged, I'd like to compare the diff of changes in this PR with the analysis that @thaJeztah performed in #116 to see if we are missing out more vendor stuff or if it is the same. |
andrewhsu
reviewed
Aug 2, 2017
| @@ -29,8 +29,9 @@ func isremount(device string, flags uintptr) bool { | |||
|
|
|||
| func mount(device, target, mType string, flags uintptr, data string) error { | |||
| oflags := flags &^ ptypes | |||
| if !isremount(device, flags) { | |||
| // Initial call applying all non-propagation flags. | |||
| if !isremount(device, flags) || data != "" { | |||
There was a problem hiding this comment.
this change is a result of not having #121 also vendor the changes to the components/engine dir
andrewhsu
reviewed
Aug 2, 2017
| @@ -44,15 +44,23 @@ type Volume struct { | |||
| UsageData *VolumeUsageData `json:"UsageData,omitempty"` | |||
| } | |||
|
|
|||
| // VolumeUsageData volume usage data | |||
| // VolumeUsageData Usage details about the volume. This information is used by the | |||
There was a problem hiding this comment.
this change is a result of not having #132 also vendor the changes to the components/engine dir
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 21, 2018
Set up default product license for community engines Upstream-commit: 7195f21 Component: packaging
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
Add top-level `make vendor` and run it.
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Set up default product license for community engines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
vendorMakefile target to ensure cli's vendor is in sync with engine.Assumes the
docker-cli-devdocker image is built first:Then sync the vendor by running
vendortarget:Closes #116