This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.06.1] Backport engine userns secrets-mounting fix #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case where we are trying to do a remount with changed filesystem specific options was missing, we need to call `mount` as well here to change those options. See #33844 for where we need this, as we change `tmpfs` options. Signed-off-by: Justin Cormack <justin.cormack@docker.com> (cherry picked from commit 3a1ab5b) Signed-off-by: Ying <ying.li@docker.com>
seemethere
pushed a commit
to seemethere/docker-ce
that referenced
this pull request
Jul 20, 2017
…g-stack-deploy Enable client side digest pinning for stack deploy Upstream-commit: 4d980880f30eddec01dbe4328e0cd656a52b502b Component: cli
thaJeztah
approved these changes
Jul 21, 2017
|
LGTM
…On 21 Jul 2017 15:07, "Sebastiaan van Stijn" ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
ping @justincormack <https://github.com/justincormack> PTAL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdcPLIgHtYCp6RmvNVpOUvGE5uX2jU8ks5sQLCZgaJpZM4Obwn8>
.
|
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 24, 2018
Add initial scripts for Ubuntu Cosmic (18.10) Upstream-commit: 06bb2c7 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 27, 2018
[18.09 backport] Update containerd to v1.2.1-rc.0 Upstream-commit: c95cf2a5d36b5448e4771a29f2ad72214a2311dd Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.06.1] Backport engine userns secrets-mounting fix
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Add initial scripts for Ubuntu Cosmic (18.10)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of moby/moby#34077. Cherry-pick moby/moby@3a1ab5b:
There was a conflict where it seems like the
syscallhad changed in engine master, but I just used thesyscallimport here.cc @justincormack @tych0 @andrewhsu