Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename filter/chain methods to filterer/filterer_chain for Ruby 2.6 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olliebennett
Copy link
Contributor

@olliebennett olliebennett commented May 30, 2019

As discussed in #24, the inclusion of the methods chain and filter by this gem conflict with Ruby 2.6's new Enumerator::Chain and Enumerable#filter (see details), resulting in broken behaviour.

This PR simply renames the filter method to filterer and the chain method to filterer_chain in order to bypass this conflict. Obviously, this requires a change in any client code, so would need a major version bump if accepted.

TODO:

  • Rename filter to filterer
  • Rename chain to filterer_chain
  • Update README usage instructions and migration for filterer v3!

@olliebennett olliebennett changed the title Rename 'chain' method to 'filter_chain' Rename filter/chain methods to filterer/filterer_chain for Ruby 2.6 May 31, 2019
@olliebennett
Copy link
Contributor Author

Hey @ajb, do you have any thoughts on this? Alternative implementation ideas?

@olliebennett
Copy link
Contributor Author

Hey @ajb - if you get a chance I'd love to get your thoughts / guidance here. 🤞 Happy to make any changes or updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant