Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of "chain" and "filter" in Ruby 2.6 #24

Open
olliebennett opened this issue Dec 29, 2018 · 2 comments
Open

Usage of "chain" and "filter" in Ruby 2.6 #24

olliebennett opened this issue Dec 29, 2018 · 2 comments

Comments

@olliebennett
Copy link
Contributor

olliebennett commented Dec 29, 2018

Ruby 2.6.0 was released this week, and introduces Enumerator::Chain and Enumerable#filter.

The filterer gem already implements the chain and filter methods on an ActiveRecord collection.

On older rubies (<2.6) everything works fine;

# Ruby 2.5.x
> User.where('1=1').chain
=> [#<User:0x00007fe8bbf5f9c3 ... etc as expected.

However, on new rubies (>2.6.0) we see the following problem;

# Ruby 2.6.0
> User.where('1=1').chain
=> #<Enumerator::Chain: ...>

It seems the simplest solution is to rename or avoid the .chain and .filter methods in this gem.

Thoughts?

@olliebennett olliebennett changed the title Usage with Ruby 2.6.0. Usage with Ruby 2.6.0 and "chain". Dec 29, 2018
@olliebennett
Copy link
Contributor Author

olliebennett commented Apr 16, 2019

In my PR (aptly numbered #26), I've worked around this Ruby 2.6 conflict with the following method renames;

filter -> filterer
chain -> filterer_chain

@olliebennett olliebennett changed the title Usage with Ruby 2.6.0 and "chain". Usage of "chain" and "filter" in Ruby 2.6 May 31, 2019
@olliebennett olliebennett reopened this May 31, 2019
@ramontayag
Copy link

@olliebennett looks like you have the active fork. @ajb what are the chances of getting him as a maintainer or at least with access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants