131 rework api #132
Merged
131 rework api #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfs
commented
Feb 16, 2024
| import org.saynotobugs.confidence.quality.object.Satisfies; | ||
|
|
||
| @StaticFactories(value = "Recur", packageName = "org.dmfs.rfc5545.confidence") | ||
| public final class EmptyRecurrenceSet extends QualityComposition<RecurrenceSet> |
There was a problem hiding this comment.
- These new Qualities still need unit tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
============================================
+ Coverage 75.09% 77.59% +2.50%
- Complexity 525 556 +31
============================================
Files 66 72 +6
Lines 2088 2089 +1
Branches 383 372 -11
============================================
+ Hits 1568 1621 +53
+ Misses 374 323 -51
+ Partials 146 145 -1 ☔ View full report in Codecov by Sentry. |
dmfs
force-pushed
the
131-rework-api
branch
5 times, most recently
from
b266ff3 to
e45fc4b
Compare
dmfs
commented
Feb 17, 2024
| } | ||
|
|
||
|
|
||
| public long getLastInstance(TimeZone timezone, long start) |
There was a problem hiding this comment.
- this functionality is still missing
dmfs
force-pushed
the
131-rework-api
branch
10 times, most recently
from
d5088ae to
fd43e7f
Compare
This implements a major refactoring of the RecurrenceSet API. The previous implementations have been removed / deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.