Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to determine if the set is infinite? #131

Closed
dgudim opened this issue Jan 1, 2024 · 4 comments
Closed

How to determine if the set is infinite? #131

dgudim opened this issue Jan 1, 2024 · 4 comments

Comments

@dgudim
Copy link

dgudim commented Jan 1, 2024

On prior versions, I could call rSet.isInfinite(), but now it's deprecated.
How do I do it in the new version? Sorry if I am not getting something

@dmfs
Copy link
Owner

dmfs commented Jan 1, 2024

hmm... that's something that the new Iterable adapter doesn't support (yet). Can you show an example of how you would use this? The Iterable implementation was intended to do only that, iterate. I'm wondering if we should extend it with this functionality or provide another way to get this info.

@dgudim
Copy link
Author

dgudim commented Jan 1, 2024

Here: https://github.com/dgudim/Scheduler/blob/master/app/src/main/java/prototype/xd/scheduler/entities/SystemCalendarEvent.java
Line 136
I want to know when the event ends, I can probably look more into it, maybe I can skip the infinity check

@dmfs
Copy link
Owner

dmfs commented Jan 2, 2024

got it. to make this work well, I'll add a few more classes and refactor the new Iterator a bit. That should be possible without any breaking changes.

dmfs added a commit that referenced this issue Feb 16, 2024
dmfs added a commit that referenced this issue Feb 17, 2024
dmfs added a commit that referenced this issue Feb 17, 2024
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
dmfs added a commit that referenced this issue Feb 17, 2024
This implements a major refactoring of the RecurrenceSet API.
The previous implementations have been removed / deprecated.
@dmfs dmfs closed this as completed in 7c36b49 Feb 17, 2024
@dmfs
Copy link
Owner

dmfs commented Feb 17, 2024

It took a while, but I've finally come to settle for a new design that should be more future proof. It's an improved version of the one I introduced before but fixes a few issues of it. First benchmarks seemed to indicate that the new implementation is even a bit faster than the previous ones. The most significant change is that it no longer returns long timestamps but DateTime values. In future I'll provide adapters to return java time instants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants