Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework NetworkUpdate workaround #950

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Commits on Jul 8, 2022

  1. Switch from github.com/libvirt/libvirt-go-xml to libvirt.org/go/libvi…

    …rtxml
    
    This is the same go module, it was renamed so that it can start
    following go module versioning (only change major version if there are
    API/ABI breakages).
    github.com/libvirt/libvirt-go-xml is no longer maintained/updated.
    cfergeau committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    8f9a82f View commit details
    Browse the repository at this point in the history
  2. Remove NetworkUpdate workaround

    The libvirt version check which is currently to decide whether to swap
    libvirt.NetworkUpdate arguments is not enough. The fix was backported to
    older libvirt in RHEL/CentOS (for example in
    libvirt-6.0.0-37.1.module+el8.5.0+13858+39fdc467 ), and the current
    version checking code would be swapping the arguments when it's no
    longer needed.
    
    This commit uses NetworkUpdateCompat which was recently introduced in
    digitalocean/go-libvirt, and which takes care of this by checking
    libvirt connection features.
    cfergeau committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    6ed7b5b View commit details
    Browse the repository at this point in the history
  3. update golangci-lint

    dmacvicar authored and cfergeau committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    d592200 View commit details
    Browse the repository at this point in the history