Rework NetworkUpdate workaround

[cfergeau]

The libvirt version check which is currently to decide whether to swap
libvirt.NetworkUpdate arguments is not enough. The fix was backported to
older libvirt in RHEL/CentOS (for example in
libvirt-6.0.0-37.1.module+el8.5.0+13858+39fdc467 ), and the current version
checking code would be swapping the arguments when it's no longer needed.

This commit uses the same code as libvirt client libraries instead, it
checks if the libvirt connection supports the new NetworkUpdate call or
not. I've tested this code with both libvirt-6.0.0-37.1 and
libvirt-6.0.0-37 and in each case, the correct call was done to
libvirt.NetworkUpdate

Please make sure you read the contributor documentation before opening a Pull Request.

[cfergeau]

I've updated this to make use of the new NetworkUpdateCompat which takes care of this at the digitalocean/go-libvirt level.

[ElCoyote27]

Thank you @cfergeau ! I hope it gets merged soonish

[cfergeau]

@dmacvicar is this missing anything to get reviewed?

[dmacvicar]

Thanks. Can you cherry-pick 0b2f708 and 7a733d2 from dmacvicar-cfergeau-network-update to get the pipeline passing?

[cfergeau]

Thanks. Can you cherry-pick 0b2f708 and 7a733d2 from dmacvicar-cfergeau-network-update to get the pipeline passing?

Done! I squashed the commit fixing linting in Remove NetworkUpdate workaround, if you prefer to keep it separate to keep authorship info, let me know!

NB: since 'Allow edits by maintainers' is checked, you could add a cfergeau remote set to git@github.com:cfergeau/terraform-provider-libvirt.git and push directly to my network-update branch instead of creating an intermediate origin/dmacvicar-cfergeau-network-update one.