Merge 2.x into Master #254
Conversation
Simply pass everything to node-sass and just hand back the results to gulp. Removed custom options like success/failure cb and sync rendering. Missing: - gulp-sourcemaps support + test
Node Sass now returns a buffer, so we don't need to turn it into a buffer for the contents
Linting modified from ibm-watson/runner for use in Node
At least the test still pass and paths looks the same with and without the relative fudge. Sourcemaps are completely wonky though and do not point at the right thing Also removes jshint since it's using eslint now
…o 2.x # By Vincent Prouillet # Via Vincent Prouillet * '2-sourcemaps' of https://github.com/Keats/gulp-sass: Sourcemap paths seem to be relative now? # Conflicts: # index.js
Updated tests accordingly
Addes `sass.sync` to allow users to compile synchronously. Wrapped the async callback in an `if` statement controlled by a `sync` option for the main function Added `renderSync` render option
# By Vincent Prouillet # Via Vincent Prouillet * '2.x' of github.com:Snugug/gulp-sass: Use plugin name const in logError # Conflicts: # index.js
Aligns with Stylish reporter (used in ESLint, jshint-stylish, etc… Removed colors from message except for which is a standard Gulp log output color Includes line and column in error report
2.x datastream
This will let you write sass.compiler.types, for example, and access the sass types without having to require it in your main app. Additionally, this lets you use a forked compiler, or a different branch of the same compiler.
Allow you to change the compiler and expose it
📝 Lighten wording on Emoji usage
Update Node Sass to 3.0
Add Contributing Guidelines
|
👀 oh hello there @Snugug 👀 |
|
HI @xzyfer! 👀 👀 👀 |
|
Hey look! Greens! @dlmanning @Keats Can we get this merged in so we can get this out the door today? I'd love to release this on the same day (within a few hours?) of the 3.0 release |
|
I'm going to write an article about the new stuff in gulp-sass 2 / libsass, hopefully done by tonight. |
|
Thanks all, y'all rock! |
|
Wahoo! @dlmanning Can we get this rolled out? Or do we now have the ability to roll those? |
|
I look forward to checking my email in the morning :) |
|
Sounds good, thanks and thanks! |
|
I don't have a npm user and to be honest, can't be arsed to create one right now. |
|
Here's the article https://blog.wearewizards.io/gulp-sass-v2-released |
This will merge 2.x into Master, paving the cowpaths for a rolled release.
Resolves #247