Allow you to change the compiler and expose it #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let you write sass.compiler.types, for example, and access the sass types without having to require it in your main app. Additionally, this lets you use a forked compiler, or a different branch of the same compiler.
|
Would have preferred an issue before a PR. We'll take a look and discuss |
|
The tests are also failing |
|
@Snugug next time I'll open an issue, but perhaps that should be made clear in the README? With regards to the tests, the same tests were failing before my change, so my commit shouldn't be changing any existing functionality. |
|
We'll make that clear in contributing guidelines for 2.x. |
|
I'm happy with this, gonna merge it in. |
Snugug
added a commit
that referenced
this pull request
Apr 29, 2015
Allow you to change the compiler and expose it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let you write
require('gulp-sass').compiler.types, for example, and accessthe new
node-sasstypes without having torequire('node-sass')in your own code.Additionally, this lets you use a forked compiler, or a different branch
of the same compiler, by overriding
require('gulp-sass').compiler.What do you think?