Allow for namespaces not defined or outside root element in single sign out requests #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chuckbjones and @njfranck: our CAS server had a very similar issue to yours that you fix in #33
Our server's specific problem was that it didn't define the
xmlns:saml
namespace at all and so its request XML looked something like this:This pull request integrates the fix for namespaces not defined on the root node as well as those not defined at all. I kept the
inject_params
method mostly similar (though slightly tidied) so that the specs would pass, and it seems thatupdate_param
actually has slightly different semantics as it leavesenv
unchanged.The approach in
add_namespaces
of adding namespaces then re-parsing the XML seems to be what's needed, as per this Stack Overflow thread.@dlindahl could you take a look at this?