Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for namespaces declared outside of the root element in single sign out requests #33

Closed
wants to merge 4 commits into from

Conversation

chuckbjones
Copy link

The CAS server I'm using declares the saml namespace inside the NameID element:

<samlp:LogoutRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" ID="foobarbaz" Version="2.0" IssueInstant="2014-10-19T17:13:50Z">
    <saml:NameID xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">@NOT_USED@</saml:NameID>
    <samlp:SessionIndex>ST-foo-bar</samlp:SessionIndex>
</samlp:LogoutRequest>

Nokogiri only looks for namespace declarations in the root element, then raises an exception when it can't find one that was declared elsewhere. This PR forces Nokogiri to scan the entire xml document for namespaces before accessing any nodes.

@nicolasfranck
Copy link

I was looking for the same thing!
Is there still working on this project?

njfranck and others added 3 commits September 1, 2015 13:57
@dlindahl
Copy link
Owner

I no longer have access to a CAS server and therefore am no longer fit to maintain this project.

If you would like to volunteer to be a maintainer of this project, please let me know by opening an Issue.

@vjt
Copy link
Collaborator

vjt commented Nov 12, 2020

Superseded by #39

@vjt vjt closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants