Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_all.d: Use git ls-remote as a fallback in getDubTag #481

Merged
merged 1 commit into from
May 13, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

GitHub's API sometimes rejects the request which fetches the available
tags with a HTTP 403. This patch uses git ls-remote as a fallback
when the current tag could not be retrieved from the API.

GitHub's API sometimes rejects the request which fetches the available
tags with a `HTTP 403`. This patch uses `git ls-remote` as a fallback
when the current tag could not be retrieved from the API.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach merged commit 4623fcf into dlang:master May 13, 2021
MoonlightSentinel pushed a commit to MoonlightSentinel/installer that referenced this pull request May 30, 2021
build_all.d: Use git ls-remote as a fallback in getDubTag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants