New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nightly build on Github Actions #12491

Merged

thewilsonator merged 1 commit into dlang:master from MoonlightSentinel:nightlies

May 20, 2021

Contributor

MoonlightSentinel commented Apr 30, 2021 •

edited

Loading

Creates a new action that generates a new release for all currently
supported targets (linux, osx, windows, freebsd) on merges to master.

The release are generated by using build_all.d from installer

~~WIP because it contains the on: pull-request trigger for testing purposes~~

~~Depends on build_all.d: Add platform selection via command line installer#480~~
~~Another PR to deal with GitHub's unreliable API: build_all.d: Use git ls-remote as a fallback in getDubTag installer#481~~

MoonlightSentinel force-pushed the nightlies branch 12 times, most recently from 202004f to a175781 Compare

May 1, 2021 17:30

maxhaton changed the title ~~Add nighly build on Github Actions~~ Add nightly build on Github Actions

MoonlightSentinel force-pushed the nightlies branch 17 times, most recently from 8fd68da to 420af4d Compare

May 2, 2021 00:27

Contributor

Imperatorn commented May 5, 2021

Any idea if godbolt also would be updated?

Contributor Author

MoonlightSentinel commented May 5, 2021 •

edited

Loading

The current implementation only uploads nightlys to the release page. Future work could either adapt those tools to use GitHub or push the nightlies to dlang.org.

MoonlightSentinel force-pushed the nightlies branch 3 times, most recently from 879f59a to 07c815f Compare

May 5, 2021 12:55

MoonlightSentinel commented

View reviewed changes

Contributor Author

MoonlightSentinel left a comment •

edited

Loading

Some thoughts / hints

.github/workflows/nightlies.yml Outdated

+                # Rebuild on merges to master
+                push:
+                  branches:
+                    - master

Contributor Author

MoonlightSentinel May 9, 2021

Not sure if this is the best trigger. The workflow could also be a "real" nightly build to automatically include changes to druntime/phobos even when there are no changes to DMD. It also would save a lot of CI time.

Contributor Author

MoonlightSentinel May 12, 2021

Switched to a daily build at 00:00 UTC

.github/workflows/nightlies.yml Outdated Show resolved Hide resolved

.github/workflows/nightlies.yml

+                            rpm \
+                            rsync \
+                            unzip \
+                            xz-utils

Contributor Author

MoonlightSentinel May 9, 2021

Some of those should already be included in the base image, but I've kept them just to be sure.

.github/workflows/nightlies.yml

+                        # Determine installed LDC version
+                        LDC=$(ldc2 --version | head -n 1 | cut -d'(' -f2 | cut -d')' -f1)
+                        echo "::set-output name=host_ldc::$LDC"

Contributor Author

MoonlightSentinel May 9, 2021

This automatically updates the host compiler with every LDC release.

.github/workflows/nightlies.yml

+                    #
+                    - name: Create the nightly release
+                      # Currently disabled due to missing permissions
+                      if: ${{ false }}

Contributor Author

MoonlightSentinel May 9, 2021 •

edited

Loading

Doesn't work due to missing permissions because the PR was issued from a fork. Could probably be enabled by another PR from an upstream branch.

See the generated artifacts for a preview of the actual releases

MoonlightSentinel force-pushed the nightlies branch from 58822fe to fbb5776 Compare

May 12, 2021 23:07

MoonlightSentinel marked this pull request as ready for review

May 13, 2021 12:59

MoonlightSentinel force-pushed the nightlies branch from fbb5776 to fc79654 Compare

May 13, 2021 12:59

Contributor

dlang-bot commented May 13, 2021

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12491"


          Add nightly builds on Github Actions

c5f715c

Creates a new action that generates a new release for all currently
supported targets (linux, osx, windows, freebsd) on merges to master.

The release are generated by using `build_all.d` from installer

MoonlightSentinel force-pushed the nightlies branch 2 times, most recently from 458d330 to c5f715c Compare

May 18, 2021 21:10

RazvanN7 approved these changes

View reviewed changes

RazvanN7 added the Merge:auto-merge label

MoonlightSentinel added Merge:auto-merge and removed Merge:auto-merge labels

Contributor Author

MoonlightSentinel commented May 20, 2021

Dlang Bot is AWOL again?

Contributor

RazvanN7 commented May 20, 2021 •

edited

Loading

@CyberShadow is migrating the bot, so it will probably be offline a bit. I assume the auto-merge label does not work. Is it problematic if I manually merge this?

thewilsonator merged commit 9443d84 into dlang:master

MoonlightSentinel deleted the nightlies branch

May 20, 2021 10:00

Contributor Author

MoonlightSentinel commented May 20, 2021

@CyberShadow is migrating the bot, so it will probably be offline a bit. I assume the auto-merge label does not work.

Thanks for the info.

Is it problematic if I manually merge this?

No.

How do we enable the final step which creates the github release? I couldn't test that step due to insufficient permissions (because this PR originates from a fork).
Can you create a branch in this repo s.t. we can test it in another PR or should I simply enable it and check the results?

Contributor

RazvanN7 commented May 20, 2021

How do we enable the final step which creates the github release? I couldn't test that step due to insufficient permissions (because this PR originates from a fork).

I also don't have sufficient permissions.

should I simply enable it and check the results?

Go for it.

Member

CyberShadow commented May 20, 2021

@CyberShadow is migrating the bot, so it will probably be offline a bit. I assume the auto-merge label does not work. Is it problematic if I manually merge this?

I don't think I've yet to do anything which would cause downtime, so that issue would be unrelated.

Member

CyberShadow commented Jun 10, 2021

I noticed two issues which I think are caused by the way these nightlies are being made available:

GitHub sends an email every few days about the nightly release
The tag seems to be rewritten every time, causing git fetch to fail (because it refuses to overwrite the moved tag by default).

@MoonlightSentinel Would it be possible to use a different approach to this that would not have these issues?

The approach used by LDC may be better. Instead of creating a new release every time, instead they update an existing release. We also use a small server-side script to allow finding download URLs for the latest release binaries programmatically.

Member

Geod24 commented Jun 10, 2021

The workflow triggers in user's forks, which might be why you are getting the emails @CyberShadow ?

Member

CyberShadow commented Jun 10, 2021

I don't think so. Here is what the email looks like:

Contributor Author

MoonlightSentinel commented Jun 10, 2021

@MoonlightSentinel Would it be possible to use a different approach to this that would not have these issues?

The approach used by LDC may be better. Instead of creating a new release every time, instead they update an existing release.

I'm sorry for the inconvinience caused by the current implementation. Updating the attached assets should be possible by switching to a different action. I'll have a look.

We also use a small server-side script to allow finding download URLs for the latest release binaries programmatically.

Note that install.sh already supports these nightlies.

Geod24 mentioned this pull request

Add support for new DMD nightlies dlang-community/setup-dlang#44

Closed

MoonlightSentinel mentioned this pull request

Nightlies: Update release instead of tagging a new one #12669

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge