Fixes for issues #5 and #6 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #5 and #6 .
Verifies that the RS-HFIQ connection is interactive before setting oscillator current levels. Still have to use slight delays due to some race condition in Serial/Linux but behavior is much more reliable (on my system anyway).
Also ensures RS-HFIQ is keyed down when Quisk is closed. Keyup may still hang on if Quisk closes with an exception, which I've seen a few times. Not sure what to do about that, as it keeps close() from being invoked and since this is effectively a driver there is no access to the main threads to wrap in an exception and apply a shutdown hook.