Task: require/allow collector_auth_token iff we are in Leader role. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches how things will be configured: helpers don't have knowledge of the leader-collector auth token. Also, update aggregator endpoint checks to return a 404 if the endpoint doesn't apply to the task role BEFORE checking auth. I think this makes more sense since I suppose the desired semantics are "the resource does not exist if the task is for the wrong role" and it doesn't make sense to authenticate against a task that doesn't exist.
tgeoghegan
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches how things will be configured: helpers don't have knowledge
of the leader-collector auth token.
Also, update aggregator endpoint checks to return a 404 if the endpoint
doesn't apply to the task role BEFORE checking auth. I think this makes
more sense since I suppose the desired semantics are "the resource does
not exist if the task is for the wrong role" and it doesn't make sense
to authenticate against a task that doesn't exist.
Closes #370.