Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsModularLatticeDigraph #629

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Add IsModularLatticeDigraph #629

merged 4 commits into from
Apr 3, 2024

Conversation

james-d-mitchell
Copy link
Member

No description provided.

@james-d-mitchell james-d-mitchell added the new-feature A label for new features. label Mar 27, 2024
@james-d-mitchell
Copy link
Member Author

@MTWhyte is going to take this to completion

@james-d-mitchell
Copy link
Member Author

@MTWhyte I've just rebased this on to main which will hopefully fix the ci, I had to force push, which might interact badly if you've already been working on this. Please let me know if you need any help

@MTWhyte
Copy link
Collaborator

MTWhyte commented Mar 28, 2024

@MTWhyte I've just rebased this on to main which will hopefully fix the ci, I had to force push, which might interact badly if you've already been working on this. Please let me know if you need any help

Cool yeah I've started on it, I'll see how it goes when I rebase

james-d-mitchell
james-d-mitchell commented Apr 3, 2024
View reviewed changes
Copy link
Member Author

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but can't approve because I'm the author, oh well

@james-d-mitchell james-d-mitchell merged commit 30ac2d7 into digraphs:main Apr 3, 2024
22 checks passed
@james-d-mitchell
Copy link
Member Author

Thanks @MTWhyte !

@james-d-mitchell james-d-mitchell deleted the is-modular-lattice branch April 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTWhyte MTWhyte Awaiting requested review from MTWhyte

Assignees
No one assigned
Labels
new-feature A label for new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-d-mitchell @MTWhyte