Apply some more linting rules #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
force-pushed
the
linting
branch
2 times, most recently
from
312875d
to
63afa08
Compare
james-d-mitchell
force-pushed
the
linting
branch
from
63afa08
to
385b107
Compare
mtorpey
reviewed
Jan 10, 2024
| local D; | ||
| D := MakeImmutable(DigraphFromSparse6String(IsMutableDigraph, s)); | ||
| SetIsSymmetricDigraph(D, true); | ||
| return D; | ||
| end); | ||
|
|
||
| InstallMethod(DigraphFromSparse6String, "for a function and a string", | ||
| [IsFunction, IsString], | ||
| DigraphFromSparse6StringCons); | ||
| [IsFunction, IsString], DigraphFromSparse6StringCons); |
There was a problem hiding this comment.
As I think Reimer Behrens once said: "vertical screen real estate is at a premium", so one less line is a good thing from this perspective.
mtorpey
reviewed
Jan 10, 2024
| fail, | ||
| "AutomorphismGroup")[1]; | ||
| end); | ||
| [IsDigraph, IsHomogeneousList], {D, colors} -> BLISS_DATA(D, colors, fail)[1]); |
There was a problem hiding this comment.
We definitely don't want the last argument in these?
There was a problem hiding this comment.
Definitely don't, I think this was a remnant of some earlier code.
mtorpey
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.