Merge pull request #601 from james-d-mitchell/linting

Apply some more linting rules

.gaplint.yml

@@ -1,2 +1,3 @@
 disable:
   - align-assignments
+duplicate-function-min-length: 4

doc/digraph.xml

@@ -752,7 +752,7 @@ gap> T := AsSemigroup(IsPartialPermSemigroup,
 gap> Size(T);
 20
 gap> D := GreensDClasses(T);;
-gap> List(D, x -> Size(x));
+gap> List(D, Size);
 [ 6, 12, 2 ]
 ]]></Example>
     </Description>

doc/examples.xml

@@ -943,7 +943,7 @@ gap> D := BondyGraph(1);
 gap> IsHamiltonianDigraph(D);
 false
 gap> G := List([1 .. 22], x -> DigraphRemoveVertex(D, x));;
-gap> ForAll(G, x -> IsHamiltonianDigraph(x));
+gap> ForAll(G, IsHamiltonianDigraph);
 true]]></Example>
   </Description>
 </ManSection>

etc/gaplint.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 set -e
 
-gaplint --disable W004 *.g gap/* doc/*.xml tst/testinstall.tst tst/standard/*.tst tst/extreme/*.tst tst/workspaces/*.tst
+gaplint --disable W004 $@ *.g gap/* doc/*.xml tst/testinstall.tst tst/standard/*.tst tst/extreme/*.tst tst/workspaces/*.tst

gap/attr.gi

@@ -154,15 +154,11 @@ end);
 
 InstallMethod(ArticulationPoints, "for a digraph by out-neighbours",
 [IsDigraphByOutNeighboursRep],
-function(D)
-  return DIGRAPHS_ArticulationPointsBridgesStrongOrientation(D)[2];
-end);
+D -> DIGRAPHS_ArticulationPointsBridgesStrongOrientation(D)[2]);
 
 InstallMethod(Bridges, "for a digraph by out-neighbours",
 [IsDigraphByOutNeighboursRep],
-function(D)
-  return DIGRAPHS_ArticulationPointsBridgesStrongOrientation(D)[3];
-end);
+D -> DIGRAPHS_ArticulationPointsBridgesStrongOrientation(D)[3]);
 
 InstallMethodThatReturnsDigraph(StrongOrientation,
 "for a digraph by out-neighbours",