Set default fstype to fix fsGroup usage #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
fix-fsgroup
branch
from
59567df
to
acec8c7
Compare
varshavaradarajan
approved these changes
Oct 30, 2020
The provisioner sidecar v2 dropped setting a default file-system type. When we upgraded, we did not set it explicitly because our driver already handles the case where no file-system is specified. As it turns out, however, the kubelet gates the application of the fsGroup security context parameter setting the file permissions of a volume on the availability of a file-system at the time the PV is created and otherwise ignores it. We restore proper functionality of fsGroup by setting the default file-system type to ext4.
timoreimann
force-pushed
the
fix-fsgroup
branch
from
acec8c7
to
9f506f2
Compare
|
Force-pushed just a changelog update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provisioner sidecar v2 dropped setting a default file-system type. When we upgraded, we did not set it explicitly because our driver already handles the case where no file-system is specified. As it turns out, however, the kubelet gates the application of the fsGroup security context parameter setting the file permissions of a volume on the availability of a file-system at the time the PV is created and otherwise ignores it.
We restore proper functionality of fsGroup by setting the default file-system type to ext4.