Skip to content

Commit

Permalink
Set default fstype to fix fsGroup usage
Browse files Browse the repository at this point in the history
The provisioner sidecar v2 dropped setting a default file-system type.
When we upgraded, we did not set it explicitly because our driver
already handles the case where no file-system is specified. As it turns
out, however, the kubelet gates the application of the fsGroup security
context parameter setting the file permissions of a volume on the
available of a file-system at the time the PV is created and otherwise
ignores it.

We restore proper functionality of fsGroup by setting the default
file-system type to ext4.
  • Loading branch information
timoreimann committed Oct 30, 2020
1 parent db77359 commit 59567df
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## unreleased

* Fix fstype usage
[[GH-362]](https://github.com/digitalocean/csi-digitalocean/pull/362)
* Match csi-provisioner RBAC rules with upstream
[[GH-360]](https://github.com/digitalocean/csi-digitalocean/pull/360)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ spec:
image: quay.io/k8scsi/csi-provisioner:v2.0.2
args:
- "--csi-address=$(ADDRESS)"
- "--default-fstype=ext4"
- "--v=5"
env:
- name: ADDRESS
Expand Down

0 comments on commit 59567df

Please sign in to comment.