Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for node volume attachment limits #303

Merged
merged 1 commit into from
Apr 24, 2020

Commits on Apr 24, 2020

  1. Enable tests for node volume attachment limits

    The csi-test sanity package ships with off-by-default tests to validate
    per-node attachment limits. This change toggles the corresponding test
    configuration flag to enable the tests.
    
    The change requires modifying our fake driver to return a 422 HTTP error
    code when the limit is exceeded. As a consequence, we also need to
    customize the IdempotentCount test setting which parameterizes the
    'should be idempotent' test that creates the given number of volumes in
    sequence. The default value of 10 causes our (fake) limit to be
    exceeded, which is why we tune it down to 5.
    
    The test also revealed that we missed to handle the case where the node
    volume attachment limit is exceed during ControllerPublishVolume. We
    extend our error handling to identify this case and return an
    RESOURCE_EXHAUSTED code accordingly.
    timoreimann committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    98c12a8 View commit details
    Browse the repository at this point in the history