Enable tests for node volume attachment limits #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
enable-and-support-testnodevolumeattachlimit
branch
from
125266b
to
4ac8311
Compare
timoreimann
force-pushed
the
update-csi-test-to-digitalocean-csi-test-at-master
branch
from
22f9d65
to
f0d2372
Compare
timoreimann
force-pushed
the
enable-and-support-testnodevolumeattachlimit
branch
from
4ac8311
to
5f38463
Compare
timoreimann
changed the base branch from
update-csi-test-to-digitalocean-csi-test-at-master
to
master
timoreimann
force-pushed
the
enable-and-support-testnodevolumeattachlimit
branch
from
5f38463
to
f203740
Compare
adamwg
approved these changes
Apr 24, 2020
driver/driver_test.go
Outdated
| return nil, resp, errors.New("droplet was not found") | ||
| } | ||
|
|
||
| if len(droplet.VolumeIDs) == maxVolumesPerNode { |
There was a problem hiding this comment.
Should we use >= maxVolumesPerNode here just to be safe?
There was a problem hiding this comment.
Yep, good call -- done.
The csi-test sanity package ships with off-by-default tests to validate per-node attachment limits. This change toggles the corresponding test configuration flag to enable the tests. The change requires modifying our fake driver to return a 422 HTTP error code when the limit is exceeded. As a consequence, we also need to customize the IdempotentCount test setting which parameterizes the 'should be idempotent' test that creates the given number of volumes in sequence. The default value of 10 causes our (fake) limit to be exceeded, which is why we tune it down to 5. The test also revealed that we missed to handle the case where the node volume attachment limit is exceed during ControllerPublishVolume. We extend our error handling to identify this case and return an RESOURCE_EXHAUSTED code accordingly.
timoreimann
force-pushed
the
enable-and-support-testnodevolumeattachlimit
branch
from
f203740
to
98c12a8
Compare
nicktate
approved these changes
Apr 24, 2020
waynr
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csi-test sanity package ships with off-by-default tests to validate per-node attachment limits. This change toggles the corresponding test configuration flag to enable the tests.
The change requires modifying our fake driver to return a 422 HTTP error code when the limit is exceeded. As a consequence, we also need to customize the IdempotentCount test setting which parameterizes the 'should be idempotent' test that creates the given number of volumes in
sequence. The default value of 10 causes our (fake) limit to be exceeded, which is why we tune it down to 5.
The test also revealed that we missed to handle the case where the node volume attachment limit is exceed during
ControllerPublishVolume. We extend our error handling to identify this case and return anRESOURCE_EXHAUSTEDcode accordingly.The PR depends on #301.