CSI spec v1.1.0 #144
Merged
CSI spec v1.1.0 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwg
reviewed
Apr 23, 2019
| ll.WithField("snapshot_id", snapshot.GetSnapshotId()).Info("using snapshot as volume source") | ||
| volumeReq.SnapshotID = snapshot.GetSnapshotId() | ||
| if contentSource != nil && contentSource.GetSnapshot() != nil { | ||
| snapshotID := contentSource.GetSnapshot().GetSnapshotId() |
There was a problem hiding this comment.
Should we validate that the snapshot ID is not empty? Not sure whether the API call below will return a NotFound or some other status when passed an empty ID.
There was a problem hiding this comment.
Good poing @adamwg. I think it'll be already validated but I'll make sure to test that as well.
The new csi-test version detected this issue. The snapshot might be deleted and we wouldn't test it.
https://kubernetes.slack.com/archives/C8EJ01Z46/p1556001245131700 From @msau42: > we're actually planning to deprecate cluster-driver-registrar and not > release a version for 1.14. Instead we are recommending that vendors > just create the CSIDriver spec as part of the driver deployment > packaging. @lpabon is currently in the process of updating all the > documentation to reflect this
Make sure we catch it and return a proper error instead of relying on the API behavior.
jcodybaker
approved these changes
Apr 29, 2019
| @@ -790,6 +810,10 @@ func (d *Driver) ListSnapshots(ctx context.Context, req *csi.ListSnapshotsReques | |||
| return listResp, nil | |||
| } | |||
|
|
|||
| func (d *Driver) ControllerExpandVolume(ctx context.Context, req *csi.ControllerExpandVolumeRequest) (*csi.ControllerExpandVolumeResponse, error) { | |||
| return nil, errors.New("not implemented yet") | |||
There was a problem hiding this comment.
Should this return codes.Unimplemented rather than a generic go error?
| cfg := &sanity.Config{ | ||
| StagingPath: mntStageDir, | ||
| TargetPath: mntDir, | ||
| TargetPath: os.TempDir() + "/csi-target", |
There was a problem hiding this comment.
For the benefit of others who are curious about this change. https://github.com/kubernetes-csi/csi-test/blob/e1f2421c7f0a0cc7f9942fea1192392f253891db/pkg/sanity/sanity.go#L56-L58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CSI spec to
v1.1.0and the sidecars to their respective largest versions.Vendoring the code separately is a breaking change, hence it had to be here. Each commit is self contained, to review, read them one by one.
v1.1.0and the csi-test library tov2.0.0v1.1.0CSIDriverbecausecluster-driver-registraris deprecated and no longer will create it for us (CSINodeInfo and CSIDriver Controller Changes kubernetes/kubernetes#74283)v1.14