driver/controller: check snapshotID for emptiness

Make sure we catch it and return a proper error instead of relying on the API behavior.
digitalocean · Apr 29, 2019 · 46155ff · 46155ff
1 parent 48d2aa0
commit 46155ff
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/driver/controller.go b/driver/controller.go
@@ -161,6 +161,9 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 	contentSource := req.GetVolumeContentSource()
 	if contentSource != nil && contentSource.GetSnapshot() != nil {
 		snapshotID := contentSource.GetSnapshot().GetSnapshotId()
+		if snapshotID == "" {
+			return nil, status.Error(codes.InvalidArgument, "snapshot ID is empty")
+		}
 
 		// check if the snapshot exist before we continue
 		_, resp, err := d.snapshots.Get(ctx, snapshotID)