Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2547: Send feedback open keyboard #2564

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

f1sh1918
Copy link
Contributor

Short description

Currently the user is not able to close the keyboard by virtual keyboard because the "Enter" button makes new lines. So the user may be confused how to close the keyboard.

Proposed changes

  • replace enter button by "done" button
  • close keyboard on done instead of new line
  • add keyboard aware view to be able to read the written text when keyboard is open

Resolved issues

Fixes: #2547


@f1sh1918 f1sh1918 force-pushed the 2547-send-feedback-open-keyboard branch from 730882b to 4bd7b0e Compare November 14, 2023 16:41
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks! I really like the input scrolling into focus when the keyboard is opened. Tested on real iOS

Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Tested on Android, works as expected

Two small thoughts:

  • react-native-keyboard-aware-scroll-view was not updated for the last two years
  • you can move the mocking of the keyboardAwareView to the .mocks folder, so it only needs to be implemented once.

@f1sh1918
Copy link
Contributor Author

Looks good 👍

Tested on Android, works as expected

Two small thoughts:

  • react-native-keyboard-aware-scroll-view was not updated for the last two years
  • you can move the mocking of the keyboardAwareView to the .mocks folder, so it only needs to be implemented once.

I didn't find any alternative for this library. Also it's not a crucial feature, so I think it's okay.
Gonna move it to mocks, thx for the hint

@f1sh1918 f1sh1918 merged commit 34d400b into main Nov 16, 2023
4 checks passed
@f1sh1918 f1sh1918 deleted the 2547-send-feedback-open-keyboard branch November 16, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not send feedback after opening the keyboard
4 participants