Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not send feedback after opening the keyboard #2547

Closed
clarabracklo opened this issue Nov 8, 2023 · 7 comments · Fixed by #2564
Closed

Can not send feedback after opening the keyboard #2547

clarabracklo opened this issue Nov 8, 2023 · 7 comments · Fixed by #2564
Assignees
Labels
Bug Something isn't working iOS only concerns ios devices

Comments

@clarabracklo
Copy link

clarabracklo commented Nov 8, 2023

I am using the native app on an iPhone (15.6.1). When opening the feedback funktion at the top right and start typing feedback I can not close the keyboard anymore and therefore can not send any feedback.

I also received the feedback from Munich that no feedback has been send since changing the functionality. Might be connected could also be because the functionality is not visible on every page footer anymore (harder to find). Handled in #2548

@clarabracklo clarabracklo added the Bug Something isn't working label Nov 8, 2023
@LeandraH LeandraH added the Android only concerns android devices label Nov 8, 2023
@LeandraH LeandraH moved this to Next Up in team-app Nov 8, 2023
@ztefanie ztefanie added the iOS only concerns ios devices label Nov 9, 2023
@ztefanie
Copy link
Member

ztefanie commented Nov 9, 2023

@LeandraH have you tested on Android or why have you added the android label?

@LeandraH
Copy link
Contributor

LeandraH commented Nov 9, 2023

Nope, sorry, must have mistyped or something

@LeandraH LeandraH removed the Android only concerns android devices label Nov 9, 2023
@f1sh1918 f1sh1918 self-assigned this Nov 14, 2023
@f1sh1918
Copy link
Contributor

@clarabracklo
you should be able to close the keyboard by clicking on the screen above the keyboard?
Since this is a Textarea and not a Textfield you are able to create multiple lines by clicking "Enter" Button.
You can either use the "Enter" Button for new line or leaving the TextField
I think the main issue is not closing the keyboard but to find the functionality in the overflow menu

@steffenkleinle
Copy link
Member

steffenkleinle commented Nov 14, 2023

@clarabracklo you should be able to close the keyboard by clicking on the screen above the keyboard? Since this is a Textarea and not a Textfield you are able to create multiple lines by clicking "Enter" Button. You can either use the "Enter" Button for new line or leaving the TextField

Not easily being able to close the keyboard was also already reported in the A11y report, so perhaps we should reassign enter to close the keyboard instead of adding a new line? Does being able to add linebreaks to the feedback comment add any benefits?

I think the main issue is not closing the keyboard but to find the functionality in the overflow menu

I think these are just two different issues and therefore should have two different tickets.
Edit: There already is #2548 for this, so we probably should just remove it from this issues description?

@f1sh1918
Copy link
Contributor

yes you are right i also thought about that. Gonna test how the TextArea behaves if you don't break by enter

@f1sh1918
Copy link
Contributor

okay i think as Steffen described the best option is to switch the "Enter" Button by "Done" button and close the keyboard. The user can not break lines manually but it will happen automatically.
i will also add a keyboard aware scroll view so the text remains visible during typing

@clarabracklo
Copy link
Author

Thank you very much! This feedback has come up during our community workshops and if there are any changes implemented I think it would be great to communicate that in our facebook group so that our users feel heard . Do you think you could possibly ping Leonie when you are done @f1sh1918 ?

@github-project-automation github-project-automation bot moved this from Next Up to Done in team-app Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iOS only concerns ios devices
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants