Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghc-lib build failure with 8.10.7 and -haddock #392

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

shayne-fletcher
Copy link
Contributor

ghc-9.2.3 flavored ghc-lib builds fail with ghc-8.10.* when -haddock is enabled due to a particular comment.

packages produced via:

stack runhaskell \
  --package extra --package optparse-applicative CI.hs -- \
  --ghc-flavor ghc-9.2.3 

tested with this cabal.project:

packages:    */*.cabal
with-compiler: /Users/shayne/ghc-8.10.7/bin/ghc
package ghc-lib-parser
  ghc-options: -j -haddock   
package ghc-lib
  ghc-options: -haddock

before the fix, cabal new-build all produces:

compiler/GHC/CmmToAsm/AArch64/CodeGen.hs:176:15: error:
    parse error on input ‘{- | debugIsOn -}’
    |
176 | ann doc instr {- | debugIsOn -} = ANN doc instr
    |               ^^^^^^^^^^^^^^^^^

after the fix cabal new-build all runs to completion.

@shayne-fletcher
Copy link
Contributor Author

shayne-fletcher commented Jul 4, 2022

Copy link
Contributor

@akrmn akrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@akrmn
Copy link
Contributor

akrmn commented Jul 5, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shayne-fletcher
Copy link
Contributor Author

@akrmn good to land?

@akrmn akrmn merged commit 7897cd5 into digital-asset:master Jul 6, 2022
@shayne-fletcher shayne-fletcher deleted the ghc-lib-bad-haddock branch July 6, 2022 16:06
@shayne-fletcher
Copy link
Contributor Author

note: a more direct way to test this configuration: stack runhaskell --resolver lts-18.16 --package extra --package optparse-applicative CI.hs -- --ghc-flavor ghc-9.2.3 --ghc-options "-haddock" --no-checkout --resolver lts-18.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghc-lib-9.2.3.20220527 doesn't build on GHC 8.10 when -haddock is enabled
2 participants