Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on GHC 8.10 when -haddock is enabled #344

Closed
georgefst opened this issue Jan 8, 2022 · 5 comments · Fixed by #345
Closed

Doesn't build on GHC 8.10 when -haddock is enabled #344

georgefst opened this issue Jan 8, 2022 · 5 comments · Fixed by #345

Comments

@georgefst
Copy link

A similar patch to #288 is needed to remove more invalid Haddock markup, this time in GHC.Exts.Heap.FFIClosures.hs (fixed upstream in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7291#note_400665). At least if we care about keeping ghc-lib buildable on GHC 8.10 with -haddock enabled.

Enabling -haddock globally is quite common as it's useful for HLS (see: haskell/haskell-language-server#209). Unfortunately, with this flag enabled, GHC 8.10 fails completely when encountering invalid markup (somewhat surprisingly, in a year and a half, this is only the second such issue I've hit, after haskell/c2hs#256). GHC 9.0 rectifies the situation by downgrading these from errors to warnings (requiring -Winvalid-haddock, which really ought to be in -Wall: https://gitlab.haskell.org/ghc/ghc/-/issues/18905) and introducing a -no-haddock flag. But in 8.10 we're stuck.

Corollary: #288 can be reverted once support for GHC 8.10 is dropped.

@shayne-fletcher
Copy link
Contributor

@shayne-fletcher
Copy link
Contributor

ghc-lib-parser-9.2.1.20220109 uploaded to hackage just now

@shayne-fletcher
Copy link
Contributor

see also digital-asset/ghc#97

@shayne-fletcher
Copy link
Contributor

@shayne-fletcher
Copy link
Contributor

reopened and added a note on https://gitlab.haskell.org/ghc/ghc/-/issues/20920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants