Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/checkbox and datepicker #251

Merged
merged 5 commits into from
Sep 1, 2021
Merged

Conversation

jsebrech
Copy link
Contributor

PR Checklist

This PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A changelog entry has been added to CHANGELOG.md if necessary

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • react application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #246 #247 #248 #249

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Dependencies were cleaned up and some were moved to peer dependencies. Should not be a breaking change, because no new dependencies were added.

Other information

Resolved issues

Fixes: #246
Fixes: #247
Fixes: #248
Fixes: #249

Copy link
Contributor

@TriangleJuice TriangleJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, Joeri! Ziet er al goed uit. Nog enkele kleine dingetjes voor na je vakantie.

Copy link
Contributor

@vademo vademo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar goede opmerkingen van @TriangleJuice maar ziet er voor de rest goed uit.
excuses voor de late review

@TriangleJuice TriangleJuice merged commit ca6e4f7 into master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants