Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox id should not be mandatory #248

Closed
jsebrech opened this issue Aug 6, 2021 · 0 comments · Fixed by #251
Closed

Checkbox id should not be mandatory #248

jsebrech opened this issue Aug 6, 2021 · 0 comments · Fixed by #251
Assignees
Labels
bug Something isn't working

Comments

@jsebrech
Copy link
Contributor

jsebrech commented Aug 6, 2021

Describe the bug

The Checkbox component requires the use of an id, while in the type definition this is optional. The id should be made optional.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://digipolisantwerp.github.io/antwerp-ui_react/#form and scroll down to Checkbox
  2. Click View Code
  3. Remove the id attribute from the code
  4. Try clicking the checkbox, it cannot be clicked anymore

Expected behavior

Checkbox should work without the id attribute.

Additional context

This issue was reported for "Regie Kinderopvang" by Aptus.

@jsebrech jsebrech added the bug Something isn't working label Aug 6, 2021
@jsebrech jsebrech self-assigned this Aug 6, 2021
jsebrech added a commit that referenced this issue Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant